Add CLI flag to parse user timestamps from h264 SEI NALs#767
Open
chenosaurus wants to merge 3 commits intomainfrom
Open
Add CLI flag to parse user timestamps from h264 SEI NALs#767chenosaurus wants to merge 3 commits intomainfrom
chenosaurus wants to merge 3 commits intomainfrom
Conversation
chenosaurus
changed the title
boks1971
approved these changes
Feb 12, 2026
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "publish-user-timestamp", | ||
| Usage: "When publishing H.264/H.265, attach the LKTS user timestamp trailer to each encoded frame (timestamp is sourced from preceding H.264 SEI user_data_unregistered when present)", |
Contributor
There was a problem hiding this comment.
mix of H.264/H.265 mention here. Mentions only H.264 SEI in details. Would be good to add H.265 details also.
Also, in join.go flag ☝️ , it only mentions H.264.
Also, join.go commands are deprecated. Would be good to not add new ones there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
--publish-user-timestampflag that enables the feature in the go server sdk to parse H264 stream for timestamps embedded in SEI NALs.